Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modyfy qti identifier regex #399

Closed
wants to merge 1 commit into from
Closed

feat: modyfy qti identifier regex #399

wants to merge 1 commit into from

Conversation

bartlomiejmarszal
Copy link
Contributor

This will fix remote publication process that is failing on new identifier format

@bartlomiejmarszal bartlomiejmarszal marked this pull request as draft June 28, 2024 12:50
julien-sebire
julien-sebire requested changes Jun 28, 2024
View reviewed changes
Copy link
Member

@julien-sebire julien-sebire left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This must not be done as it would break compatibility with QTI. Identifiers can’t begin with a digit.

@julien-sebire julien-sebire requested a review from bugalot June 28, 2024 13:24
bugalot
bugalot approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@bugalot bugalot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error, I didn't want to approve 🙃

@bugalot bugalot self-requested a review June 28, 2024 13:28
bugalot
bugalot requested changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@bugalot bugalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys :) ! We can't do this, unfortunately. This rule is expressed by the QTI XSD Schema. Letting this happen means that we accept items not matching the official IMS validator.

@bartlomiejmarszal bartlomiejmarszal deleted the feat/AUT-3705/update-item-qti-identifer branch July 1, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-sebire julien-sebire julien-sebire requested changes

@bugalot bugalot bugalot requested changes

@tikhanovichA tikhanovichA Awaiting requested review from tikhanovichA

@pnal pnal Awaiting requested review from pnal

@Karol-Stelmaczonek Karol-Stelmaczonek Awaiting requested review from Karol-Stelmaczonek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartlomiejmarszal @bugalot @julien-sebire